This repository was archived by the owner on Sep 22, 2024. It is now read-only.
Improve pseudo random seed state feature#21
Open
sebb7 wants to merge 3 commits intolambdaacademy:masterfrom
Open
Improve pseudo random seed state feature#21sebb7 wants to merge 3 commits intolambdaacademy:masterfrom
sebb7 wants to merge 3 commits intolambdaacademy:masterfrom
Conversation
With implemented random seed feature previous test fails for every start seed other than 1.
Now the supervisor is given a default start seed from config.exs or a seed from Ex.Unit in test environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now a simple configuration related to a start seed is present. A supervisor is given a default start seed from config.exs or a seed from Ex.Unit in test environment. What do you think?
I also needed to change one test which was failing with a start seed different than 1.